Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For dotnet #32109

Closed
wants to merge 35 commits into from
Closed

For dotnet #32109

wants to merge 35 commits into from

Conversation

xgqt
Copy link
Member

@xgqt xgqt commented Jul 30, 2023

Migrated from the mailing list

xgqt added 7 commits July 30, 2023 15:30
Bug: https://bugs.gentoo.org/900597
Bug: gentoo#29309
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Bug: https://bugs.gentoo.org/900597
Bug: gentoo#29309
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Bug: https://bugs.gentoo.org/900597
Bug: gentoo#29309
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Bug: https://bugs.gentoo.org/900597
Bug: gentoo#29309
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Bug: https://bugs.gentoo.org/900597
Bug: gentoo#29309
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xgqt
Areas affected: ebuilds, eclasses
Packages affected: app-eselect/eselect-dotnet, dev-dotnet/dotnet-runtime-nugets, dev-dotnet/dotnet-sdk-bin

app-eselect/eselect-dotnet: @gentoo/proxy-maint (new package)
dev-dotnet/dotnet-runtime-nugets: @gentoo/proxy-maint (new package)
dev-dotnet/dotnet-sdk-bin: @gentoo/dotnet

Linked bugs

Bugs linked: 900597


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 30, 2023
@xgqt xgqt requested a review from mgorny July 30, 2023 20:44
xgqt added 3 commits July 30, 2023 23:09
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@xgqt xgqt requested a review from thesamesam July 30, 2023 21:31
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-30 21:41 UTC
Newest commit scanned: 300be71
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6ef178834d/output.html

xgqt added 2 commits July 31, 2023 00:27
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-30 23:11 UTC
Newest commit scanned: f0e7183
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7fe49adbfc/output.html

xgqt added 3 commits July 31, 2023 09:04
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-31 07:21 UTC
Newest commit scanned: a8fc3f1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6c02a0df9a/output.html

@xgqt
Copy link
Member Author

xgqt commented Jul 31, 2023

here are some ideas for dotnet-pkg-utils rename:

  • dotnet-pkg-common
  • dotnet-pkg-simple
  • dotnet-pkg-base

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-31 07:36 UTC
Newest commit scanned: fced3ac
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f373eda708/output.html

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-07-31 11:26 UTC
Newest commit scanned: 01d979a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/321c0f3b6a/output.html

xgqt added 2 commits July 31, 2023 14:54
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-15 10:36 UTC
Newest commit scanned: ba7380b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/836cfa810b/output.html

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-19 11:01 UTC
Newest commit scanned: 56f8511
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1cedbd0fe0/output.html

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-19 17:51 UTC
Newest commit scanned: aa94916
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/14fa2f91a0/output.html

@xgqt
Copy link
Member Author

xgqt commented Aug 26, 2023

@zmedico as last .NET pkg maint please take a look at this

@xgqt
Copy link
Member Author

xgqt commented Aug 26, 2023

@thesamesam Any comments to the current state?

# Create a magic workloads file, bug #841896
local featureband
featureband="$(ver_cut 3)" # e.g. 404
featureband="${featureband:0:1}00" # e.g. 404 -> 400
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but perhaps the following would be more self-explanatory:

Suggested change
featureband="${featureband:0:1}00" # e.g. 404 -> 400
featureband="$(( $(ver_cut 3) / 100 * 100 ))" # e.g. 404 -> 400

Comment on lines 114 to 115
case "${nuget_api}" in
*/v2 | */v2/ )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

Suggested change
case "${nuget_api}" in
*/v2 | */v2/ )
case ${nuget_api%/} in
*/v2 )

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-08-29 12:16 UTC
Newest commit scanned: 4aeef2d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5062ccd360/output.html

Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-09-05 19:56 UTC
Newest commit scanned: 2dd744c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9b7738cf05/output.html

@xgqt
Copy link
Member Author

xgqt commented Sep 6, 2023

The 3rd revision of patches was sent to the miling list yesterday (06.09.2023).

Tatsh added a commit to Tatsh/tatsh-overlay that referenced this pull request Sep 7, 2023
Tatsh added a commit to Tatsh/tatsh-overlay that referenced this pull request Sep 7, 2023
Tatsh added a commit to Tatsh/tatsh-overlay that referenced this pull request Sep 7, 2023
Tatsh added a commit to Tatsh/tatsh-overlay that referenced this pull request Sep 7, 2023
@xgqt
Copy link
Member Author

xgqt commented Sep 7, 2023

Minor lints if you are interested:

Tatsh/tatsh-overlay@2fcd2b2 Tatsh/tatsh-overlay@a963cab#diff-deeb571163badabac5361245cc2f12c2299fee710bb38dbab22f3792f89458f9 Tatsh/tatsh-overlay@661640e#diff-d29bfa3ffcf8384946c0f9d536ee52d8f3e3f9dfe12a7c908326b65696a7da71

Those will be added before merging the patches sent to the dev mailing list as they are very minor improvements. Some of those I will also leave out.

gentoo-bot pushed a commit that referenced this pull request Sep 15, 2023
common functions and variables for handling .NET NuGets

Bug: https://bugs.gentoo.org/900597
Bug: #32109
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Sep 15, 2023
common functions and variables for builds using .NET SDK

Bug: https://bugs.gentoo.org/900597
Bug: #32109
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Sep 15, 2023
common functions and variables for .NET packages

Bug: https://bugs.gentoo.org/900597
Bug: #32109
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Sep 15, 2023
gentoo-bot pushed a commit that referenced this pull request Sep 15, 2023
Bug: https://bugs.gentoo.org/900597
Bug: #32109
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Sep 15, 2023
gentoo-bot pushed a commit that referenced this pull request Sep 15, 2023
Bug: https://bugs.gentoo.org/900597
Bug: #32109
Signed-off-by: Maciej Barć <xgqt@gentoo.org>
@xgqt
Copy link
Member Author

xgqt commented Sep 15, 2023

Merged. Closing. Thanks to everybody who participated!

@xgqt xgqt closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package.
Projects
None yet
5 participants