eclean : deal with invalid binpkgs #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs backup code to handle older portage versions without invalid_paths attribute as discussed in chat |
|
Please also add a test for these changes |
On it |
|
On it |
dol-sen
reviewed
Mar 25, 2023
hyprsyd
changed the title
|
|
dol-sen
reviewed
Apr 6, 2023
changes required in portage -> gentoo/portage#1016 gentoo bug -> https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
ArsenArsen
reviewed
Jul 16, 2023
Modifying an incorrect error message
gentoo-bot
pushed a commit
to gentoo/portage
that referenced
this pull request
Aug 21, 2023
Add object invalid_paths for new eclean feature to deal with invalid binpkgs. This is needed for gentoolkit's eclean to handle cleaning up invalid binpkgs. gentoolkit side PR: gentoo/gentoolkit#28 Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: #1016 Signed-off-by: Sam James <sam@gentoo.org>
|
Merged, thank you! I'm sorry for taking ages and thank you for being so patient. commit a16d0d4 (HEAD -> master, origin/master, origin/HEAD) commit d936026 |
palao
pushed a commit
to palao/portage
that referenced
this pull request
Oct 16, 2023
Add object invalid_paths for new eclean feature to deal with invalid binpkgs. This is needed for gentoolkit's eclean to handle cleaning up invalid binpkgs. gentoolkit side PR: gentoo/gentoolkit#28 Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#1016 Signed-off-by: Sam James <sam@gentoo.org>
palao
pushed a commit
to palao/portage
that referenced
this pull request
Oct 22, 2023
Add object invalid_paths for new eclean feature to deal with invalid binpkgs. This is needed for gentoolkit's eclean to handle cleaning up invalid binpkgs. gentoolkit side PR: gentoo/gentoolkit#28 Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#1016 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.