Suppress invalid binary error from portage #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zmedico
reviewed
Oct 5, 2023
pym/gentoolkit/eclean/search.py
Outdated
| @@ -573,7 +573,7 @@ def findPackages( | |||
| settings = var_dbapi.settings | |||
| bin_dbapi = portage.binarytree(pkgdir=pkgdir, settings=settings).dbapi | |||
| if "force_reindex" in signature(bin_dbapi.bintree.populate).parameters: | |||
| bin_dbapi.bintree.populate(force_reindex=True) | |||
| bin_dbapi.bintree.populate(force_reindex=True, invalid_errors=False) | |||
There was a problem hiding this comment.
Could test if invalid_errors is supports, like:
pop_sig_params = signature(bin_dbapi.bintree.populate).parameters
populate_kwargs = {}
if "invalid_errors" in pop_sig_params:
populate_kwargs["invalid_errors"] = False
bin_dbapi.bintree.populate(force_reindex=True, **populate_kwargs)There was a problem hiding this comment.
Thanks @zmedico I forgot again :-(
hyprsyd
force-pushed
the
Fix
branch
3 times, most recently
from
f5843fc
to
193f3cd
Compare
Last implemention was importing binhost module incorectly. Calling Modules() from portage.module which sets binhost var to the BinhostHandler class would always fail as it needs name and namepath leading to always call emaint via a subprocess call. Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
gentoo-bot
pushed a commit
to gentoo/portage
that referenced
this pull request
Oct 8, 2023
Introduce 'invalid_errors' var to enable suppression of invalid binary error, for use by gentoolkit. [sam: See gentoolkit side at gentoo/gentoolkit#35]. Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: #1123 Signed-off-by: Sam James <sam@gentoo.org>
hyprsyd
added a commit
to hyprsyd/gentoolkit
that referenced
this pull request
Oct 9, 2023
[sam: Note that this needs gentoo/portage#1123 on the Portage side.] Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#35 Signed-off-by: Sam James <sam@gentoo.org>
palao
pushed a commit
to palao/portage
that referenced
this pull request
Oct 16, 2023
Introduce 'invalid_errors' var to enable suppression of invalid binary error, for use by gentoolkit. [sam: See gentoolkit side at gentoo/gentoolkit#35]. Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#1123 Signed-off-by: Sam James <sam@gentoo.org>
palao
pushed a commit
to palao/portage
that referenced
this pull request
Oct 22, 2023
Introduce 'invalid_errors' var to enable suppression of invalid binary error, for use by gentoolkit. [sam: See gentoolkit side at gentoo/gentoolkit#35]. Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#1123 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pkgindex.py and Suppress invalid binary error from portage.
see also: gentoo/portage#1123