Skip to content

Commit

Permalink
fix catppuccin-neovim v1.7.0 ebuild
Browse files Browse the repository at this point in the history
Signed-off-by: Omar <somerand0mcat@hotmail.com>
  • Loading branch information
Omar committed Jun 24, 2024
1 parent e45c496 commit 9253499
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions x11-themes/catppuccin-neovim/catppuccin-neovim-1.7.0.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@
EAPI=8
DESCRIPTION="Soothing pastel theme for Neovim"
HOMEPAGE="https://github.com/catppuccin/nvim"
SRC_URI="https://github.com/catppuccin/nvim/archive/refs/tags/v"${PV}".tar.gz -> catppuccin-neovim-"${PV}".tar.gz"
S=""${WORKDIR}"/nvim-"${PV}""
SRC_URI="https://github.com/catppuccin/nvim/archive/refs/tags/v${PV}.tar.gz -> ${P}.tar.gz"
S="${WORKDIR}/nvim-${PV}"
LICENSE="MIT"
SLOT="0"
KEYWORDS="~amd64"
DEPEND="app-editors/neovim"

src_unpack() {
tar -xpf /var/tmp/portage/x11-themes/catppuccin-neovim-"${PV}"/distdir/catppuccin-neovim-"${PV}".tar.gz
}

src_install() {
cd ./colors
mkdir --parents "${D}"/usr/share/nvim/runtime/colors
cp -r *.vim "${D}"/usr/share/nvim/runtime/colors
cd ..

This comment has been minimized.

Copy link
@stkw0

stkw0 Jun 25, 2024

Contributor

add || die at the end of all non-ebuild commands, like cd, cp, mkdir, rm, and so on. Preferably, use https://devmanual.gentoo.org/function-reference/install-functions/

cd ./lua
mkdir --parents "${D}"/usr/share/nvim/runtime/lua
cp -r ./* "${D}"/usr/share/nvim/runtime/lua
}

5 comments on commit 9253499

@stkw0
Copy link
Contributor

@stkw0 stkw0 commented on 9253499 Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I will recommend using pkgdev, which already creates the commit message with the standard commit format

@somerand0mcat
Copy link
Contributor

@somerand0mcat somerand0mcat commented on 9253499 Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stkw0 i think your replying to a commit which is a old version of catppuccin-neovim

@somerand0mcat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new version is using insinto and doins to install so you dont really need || die

@stkw0
Copy link
Contributor

@stkw0 stkw0 commented on 9253499 Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mainly wanted to comment on the commit format and didn't check the other commits. Thanks!

@somerand0mcat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats ok, your welcome :)

Please sign in to comment.