-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
Signed-off-by: Omar <somerand0mcat@hotmail.com>
- Loading branch information
There are no files selected for viewing
5 comments
on commit 9253499
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I will recommend using pkgdev, which already creates the commit message with the standard commit format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stkw0 i think your replying to a commit which is a old version of catppuccin-neovim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new version is using insinto
and doins
to install so you dont really need || die
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mainly wanted to comment on the commit format and didn't check the other commits. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats ok, your welcome :)
add
|| die
at the end of all non-ebuild commands, like cd, cp, mkdir, rm, and so on. Preferably, use https://devmanual.gentoo.org/function-reference/install-functions/