Allow adding repositories recursively #40
Conversation
|
overall, looks good. just the one configparser issue |
layman/overlays/source.py
Outdated
| try: | ||
| import configparser | ||
| except ImportError: | ||
| import ConfigParser as configparser |
There was a problem hiding this comment.
You added configparser import, but I don't see it used in the remaining patch.
Doe sit get used in a later patch? I haven't looked yet. If so, it should be in the patch that uses it.
There was a problem hiding this comment.
Ah, just noticed it (a leftover).
Hummer12007
force-pushed
the
recursive
branch
2 times, most recently
from
1ca81f8
to
39b73c6
Compare
|
How were you thinking of dealing with the main repo? in this case "gentoo" We have been trying to get way from the main-repo configuration. |
|
lgtm |
|
I was thinking (about other distros) and figured out that there's no universal solution (apart from looking at repos.conf). And anyway, it just prompts before adding each repo, so the user will have to react (and willingfully accept the repo). |
|
oh, instead of hard coding the special case. Why don't we add another config item for it. Then it is easily changed... provided-masters: it can be a list like the old overlays and some other variables in the config |
Hummer12007
force-pushed
the
recursive
branch
2 times, most recently
from
7d17fce
to
b848857
Compare
|
Done. |
If it's acceptable to use the portage api, then something like this would work: Python 3.4.5 (default, Mar 12 2017, 00:44:50)
[GCC 4.9.3] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import portage
>>> 'gentoo' in portage.settings.repositories
True |
|
From what I've seen, portage APIs are only used in a module or two (not in "core" layman). |
layman/overlays/source.py
Outdated
| masters = '='.join(s[1:]).strip().split(' ') | ||
| break | ||
| return list(set(masters) - | ||
| set(self.config['provided_masters'].strip().split(' '))) |
There was a problem hiding this comment.
I would perform filtering like this inside the LaymanAPI.add_repos method, since otherwise this get_masters method is not usable as a means to get a full set of masters.
layman/overlays/source.py
Outdated
| if (len(s) < 2): continue | ||
| k = s[0].strip() | ||
| if (k == 'masters'): | ||
| masters = '='.join(s[1:]).strip().split(' ') |
There was a problem hiding this comment.
Generally, it's better to use split() instead of split(' '), since split() works correctly with multiple spaces and tabs.
|
Yeah, I tried to keep from using portage api's as much as possible. That way it would be easier to incorporate and.or use in different package managers. The news system is configurable to the point that a custom module could be used, but defaults to the portage API. This looks really good now. I like it. Zac, by using the provided_masters config, it makes it possible for users to add masters not under layman control, not just the main "gentoo" repo. |
It you have a way to query the names of configured repositories then you don't need that. For example, the app-portage/gentoopm package provides a gentoopmq tool that can do it: |
|
Problems may arise in some corner cases when using gentoopmq API, seems to me, esp. when the user has several package managers installed, additionally, in case the downstream distro maintains their own version of the portage tree (named differently than 'gentoo', albeit kept in ~sync with the upstream tree). |
|
Funtoo is in the process of splitting the repository up into logical groups. That they feel would be better for maintaining things like a stable xorg. A user could then also exclude certain sub-repos they don't need. The split repos could then use branches for different stability stages instead of just {'',-arch,~arch, arch} |
See https://bugs.gentoo.org/545568