Initial support for creating interfaces through "ip link" from iproute2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original idea and patch by Joseph Glanville <joseph.glanville@orionvm.com.au> https://gist.github.com/josephglanville/2757336
robbat2
requested changes
Jan 27, 2017
| eval link=\$iplink_${IFVAR} | ||
| if [ -n "${link}" ]; then | ||
| local ipproto='' | ||
| [ "${tunnel##mode ip6gre}" != "${tunnel}" ] && ipproto='-6' |
There was a problem hiding this comment.
How about using a case statement here instead of the multiple if conditions?
case $tunnel in
*mode\ ip6*) ipproto='-6' ;;
esac
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 27, 2017
New functionality & improvements: - Wireless: 'iw' module to replace older 'iwconfig' module. (Brian Evans <grknight@gentoo.org>) - iproute2: VXLAN & GRETAP support (iplink_$IFVAR) (Sergey Popov <pinkbyte@gentoo.org>) - Bonding: ARP IP targets (Marc Schiffbauer <mschiff@gentoo.org>) - wpa_supplicant: better matching of wired connections (Henning Schild <henning@hennsch.de>) - IPv6: clearer message for Tentative duplicate address detection (DAD). - Refactor veinfo printing of iproute2 commands. Fixes: - Avoid moduleslist race condition (Hagbard Celine <hagbardcelin@gmail.com>) - Delete IPv6 tunnel correctly (stkchp <s@tkch.net>) Bug: https://bugs.gentoo.org/638836 Bug: https://bugs.gentoo.org/637474 Bug: https://bugs.gentoo.org/636846 Bug: gentoo/netifrc#24 Bug: gentoo/netifrc#26 Bug: gentoo/netifrc#25 Bug: gentoo/netifrc#27 Package-Manager: Portage-2.3.16, Repoman-2.3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - tiny rework of simple patch[1], that somehow is not included in netifrc yet
Works like a charm and remove burden of messing with preup() and postdown()
Unfortunately, there is not easy way to determine if this link interface was created manually from iproute2 or given by system itself(it is easy with tunnels though as it's separate command), so, as a precaution, only "tested" tunnels were added for now(gretap and vxlan)
[1] - https://gist.github.com/josephglanville/2757336