Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qlop: Fixed --running --verbose returning unknown ETA. #15

Closed
wants to merge 1 commit into from
Closed

qlop: Fixed --running --verbose returning unknown ETA. #15

wants to merge 1 commit into from

Conversation

jaakristioja
Copy link
Contributor

@jaakristioja jaakristioja commented Feb 11, 2022

It seems that this was broken during the introduction of --predict in commit 13402fb which caused keys of the merge_averages and unmerge_averages sets to include version information, whereas --running expects these not to include version information.

Bug: https://bugs.gentoo.org/807975
Signed-off-by: Jaak Ristioja <jaak@ristioja.ee>

@Sophira
Copy link

Sophira commented Feb 11, 2022

Worth noting: This change causes warnings to appear when compiling:

qlop.c: In function ‘do_emerge_log’:
qlop.c:801:16: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
  801 |        verbose && !flags->do_running)
      |        ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
qlop.c:946:16: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
  946 |        verbose && !flags->do_running)
      |        ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~

Otherwise, this seems to work well on my system. Thank you! (Note: I am the original person who opened the bug.)

It seems that this was broken during the introduction of --predict in commit
13402fb which caused keys of the merge_averages
and unmerge_averages sets to include version information, whereas --running
expects these not to include version information.

Bug: https://bugs.gentoo.org/807975
Signed-off-by: Jaak Ristioja <jaak@ristioja.ee>
@jaakristioja
Copy link
Contributor Author

@Sophira Thanks! Added some parenthesis to fix these warnings.

@grobian
Copy link
Member

grobian commented Feb 12, 2022

thanks, pushed

@grobian grobian closed this Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants