depgraph.py: type annotations #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berin Aniesh <berinaniesh@gmail.com>
|
LGTM & adds no new mypy errors. |
thesamesam
reviewed
Jun 14, 2023
| @@ -100,6 +100,10 @@ | |||
| from _emerge.resolver.circular_dependency import circular_dependency_handler | |||
| from _emerge.resolver.output import Display, format_unmatched_atom | |||
|
|
|||
| # Type annotation imports | |||
| from typing import Any, Optional, Dict, List, Tuple, Union | |||
| from _emerge.stdout_spinner import stdout_spinner | |||
There was a problem hiding this comment.
For these, I would really just quote the full type in references to avoid an unnecessary import.
There was a problem hiding this comment.
Done in a5b4eb5. The motivation here being imports are slow and Portage already does a looooot of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.