lib/portage/gpg.py: send gpg output to stdout, then send stdout to /dev/null #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewAmmerlaan
force-pushed
the
master
branch
from
e10f193
to
ccb8819
Compare
floppym
reviewed
Aug 23, 2023
|
Upon further thought, I think we should just pass |
…ev/null GnuPG removes the --output file on failure. Removing /dev/null breaks all kinds of things. Instead of telling GnuPG to output to /dev/null we output to stdout and then send the stdout to /dev/null, this avoids the problem where /dev/null is removed when the key fails to unlock. Closes: https://bugs.gentoo.org/912808 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AndrewAmmerlaan
force-pushed
the
master
branch
from
ccb8819
to
3bf7b48
Compare
Sure, this is also fine by me. |
floppym
approved these changes
Aug 23, 2023
AndrewAmmerlaan
changed the title
|
Closed via 9d27833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GnuPG removes the --output file on failure. Removing /dev/null breaks all kinds of things. So lets use a temporary file for the output instead.
If the file already exists then we remove it to prevent GnuPG from complaining about the file already existing and asking us if we want to choose a different --output file.
Closes: https://bugs.gentoo.org/912808