Run PORTAGE_TRUST_HELPER before remote binary package operations #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
reviewed
Aug 30, 2023
thesamesam
reviewed
Sep 1, 2023
thesamesam
reviewed
Sep 1, 2023
thesamesam
approved these changes
Sep 1, 2023
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Right now this is somewhat suboptimal because the helper is only called if FEATURES="binpkg-request-signature" is set, but existing signatures are also verified otherwise. Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
floppym
reviewed
Sep 2, 2023
floppym
reviewed
Sep 2, 2023
floppym
reviewed
Sep 2, 2023
floppym
reviewed
Sep 2, 2023
floppym
reviewed
Sep 2, 2023
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
floppym
reviewed
Sep 3, 2023
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
palao
pushed a commit
to palao/portage
that referenced
this pull request
Oct 16, 2023
Right now this is somewhat suboptimal because the helper is only called if FEATURES="binpkg-request-signature" is set, but existing signatures are also verified otherwise. Closes: gentoo#1085 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
palao
pushed a commit
to palao/portage
that referenced
this pull request
Oct 22, 2023
Right now this is somewhat suboptimal because the helper is only called if FEATURES="binpkg-request-signature" is set, but existing signatures are also verified otherwise. Closes: gentoo#1085 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested to do what it's supposed to do...