Detect and handle unnecessary package reinstall (bug 915494) #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
7 times, most recently
from
1dec035
to
867755a
Compare
zmedico
changed the title
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
from
867755a
to
c552b86
Compare
zmedico
changed the title
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
from
c552b86
to
10c0789
Compare
|
I suppose you can't come up with a test case without say, andrew's vdb? I keep thinking we should have some way of summarising/serialising the "important bits" of a vdb so users can just run a command and dump it for the purposes of reproducing bugs.. |
|
Well, lib/portage/tests/resolver/soname/test_skip_update.py::SonameSkipUpdateTestCase::testSonameSkipUpdate can suffice as a test case if I add a parameter to disable prune_rebuilds backtracking. I'll do that now... |
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
from
10c0789
to
fde0b4f
Compare
Now testSonameSkipUpdateNoPruneRebuilds will fail if _eliminate_rebuilds doesn't do the job that prune_rebuilds backtracking does in testSonameSkipUpdate. |
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
from
fde0b4f
to
f46ddfe
Compare
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
from
f46ddfe
to
b04acb3
Compare
zmedico
commented
Oct 12, 2023
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
4 times, most recently
from
099921c
to
addfe5a
Compare
Compare package rebuilds/reinstalls to installed packages of the same exact version, and eliminate unecessary rebuilds/reinstalls triggered solely by the @__auto_slot_operator_replace_installed__ set. This is careful to obey the user's wishes if they have explicitly requested for a package to be rebuilt or reinstalled for some reason. The SonameSkipUpdateTestCase::testSonameSkipUpdateNoPruneRebuilds test case shows that the new depgraph._eliminate_rebuilds method eliminates a backtracking run that is needed for the testSonameSkipUpdate test case to succeed via prune_rebuilds backtracking which was added for bug 439688. Bug: https://bugs.gentoo.org/915494 Signed-off-by: Zac Medico <zmedico@gentoo.org>
zmedico
force-pushed
the
bug_439688_identical_binpkg_unecessary_reinstall
branch
from
addfe5a
to
4978b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare package rebuilds/reinstalls to installed packages of the same
exact version, and eliminate unecessary rebuilds/reinstalls triggered
solely by the
@__auto_slot_operator_replace_installed__set. This iscareful to obey the user's wishes if they have explicitly requested
for a package to be rebuilt or reinstalled for some reason.
The SonameSkipUpdateTestCase::testSonameSkipUpdateNoPruneRebuilds
test case shows that the new depgraph._eliminate_rebuilds method
eliminates a backtracking run that is needed for the
testSonameSkipUpdate test case to succeed via prune_rebuilds
backtracking which was added for bug 439688.
Bug: https://bugs.gentoo.org/915494