Convert portageq helper to a function #1164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floppym
force-pushed
the
portageq-function
branch
from
9f345eb
to
3c4b135
Compare
floppym
changed the title
floppym
force-pushed
the
portageq-function
branch
2 times, most recently
from
e5f6b2c
to
0e1a77a
Compare
ulm
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Please also remove the following line from bin/portageq-wrapper:
--- portage/bin/portageq-wrapper
+++ portage/bin/portageq-wrapper
@@ -9,7 +9,6 @@
set -f # in case ${PATH} contains any shell glob characters
for path in "${PORTAGE_BIN_PATH}" ${PATH}; do
- [[ ${path} == */portage/*/ebuild-helpers* ]] && continue
[[ -x ${path}/portageq ]] || continue
PYTHONPATH=${PORTAGE_PYTHONPATH:-${PORTAGE_PYM_PATH}} \
exec "${PORTAGE_PYTHON:-/usr/bin/python}" "${path}/portageq" "$@"
This keeps it out of PATH in ebuilds to avoid breaking external utilities that call portageq. Bug: https://bugs.gentoo.org/906129 Bug: https://bugs.gentoo.org/916287 Bug: https://bugs.gentoo.org/916296 Signed-off-by: Mike Gilbert <floppym@gentoo.org>
floppym
force-pushed
the
portageq-function
branch
from
0e1a77a
to
43a9db2
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps it out of PATH in ebuilds to avoid breaking external utilities that call portageq.
Bug: https://bugs.gentoo.org/906129
Bug: https://bugs.gentoo.org/916287
Bug: https://bugs.gentoo.org/916296