tests: resolver: test_use_dep_defaults.py: add test for || () dep int… #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
force-pushed
the
systemd-use-flag-rename
branch
2 times, most recently
from
2568017
to
57a36f9
Compare
…eraction Bug: https://bugs.gentoo.org/917145 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
force-pushed
the
systemd-use-flag-rename
branch
from
57a36f9
to
1929ec1
Compare
thesamesam
commented
Nov 11, 2023
| success=False, | ||
| ambiguous_merge_order=True, | ||
| options={ | ||
| "--autounmask": "n", |
There was a problem hiding this comment.
I'm not sure if we have a way to test for the ".. is required to complete your request" bit, so I'll drop this one if I can't figure out a way.
zmedico
reviewed
Nov 13, 2023
| !sys-kernel/installkernel-gentoo | ||
| || ( | ||
| sys-apps/systemd[gnuefi(-)] | ||
| sys-apps/systemd[kernel-install(-)] |
There was a problem hiding this comment.
Why not swap the order of preference for gnuefi vs. kernel-install flags? Since neither one is satisfied, dep_zapdeps will prefer the one on the left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eraction
Bug: https://bugs.gentoo.org/917145