Qa command not found improvements #1210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eli-schwartz
commented
Dec 20, 2023
eli-schwartz
commented
- check for dash as well
- don't special case and ignore errors in ./configure scripts
thesamesam
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
I'd prefix the commit msgs with ebuild: as that's the relevant component.
It looks good to me but I'd like @zmedico to take a quick look because he authored the original change to suppress it for configure.
|
Will fix up the commit messages tomorrow as I've already gone to bed. :D |
zmedico
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
The command_not_found_exclude_re traces back to 930bbbf for https://bugs.gentoo.org/245716 and I guess it's fine to remove and see if anyone complains.
calling this "bash_command_not_found" is overly specific. Just because bash is used to detect the case doesn't mean it's specific to bash. And really we should extend this find command_not_found for other environments too. Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Bug: https://bugs.gentoo.org/822033 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
…/configure Down through the twisting trail of history, we find a 2008 bug report and commit 930bbbf, which disabled detecting "command not found" in ./configure scripts with the following rationale: > This is actually a false positive. I'll fix it to filter out the ones that are generated by configure scripts. As far as I can tell it wasn't a false positive though. Looking up the source code for that old project reveals no indication that it can misfire in "expected" ways. More generally, this obscures real issues in configure scripts -- why should configure scripts be special here? -- which have *zero* guarantee of resulting in failure. Anecdotally, they usually do not. Whatever the underlying issue is, it's *definitely* an upstream bug and *almost certainly* indicates that there may be situations where the project miscompiles against expectations. Bug: https://bugs.gentoo.org/245716 Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
eli-schwartz
force-pushed
the
qa-command-not-found
branch
from
5f44525
to
e09364b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.