ebuild.sh: Warn about colon-separated argument in sandbox functions #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two comments:
Thank you! |
According to PMS and the Devmanual, only a single item is allowed as argument for addread, addwrite, adddeny and addpredict: https://projects.gentoo.org/pms/8/pms.html#x1-12300012.3.3 https://devmanual.gentoo.org/function-reference/sandbox-functions/ The previous usage message (contrary to Devmanual policy) had been added in commit 0c64542. Bug: https://bugs.gentoo.org/920654 Signed-off-by: Ulrich Müller <ulm@gentoo.org>
ulm
force-pushed
the
sandbox-functions
branch
from
a12f831
to
cb788dd
Compare
1 task
Both done. |
thesamesam
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to PMS and the Devmanual, only a single item is allowed as argument for addread, addwrite, adddeny and addpredict:
https://projects.gentoo.org/pms/8/pms.html#x1-12300012.3.3
https://devmanual.gentoo.org/function-reference/sandbox-functions/
Bug: https://bugs.gentoo.org/920654