Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: Handle unpack_metadata SignatureException in _run_pkg_pretend #1217

Conversation

zmedico
Copy link
Member

@zmedico zmedico commented Dec 26, 2023

This will handle the InvalidSignature exception that triggered bug 920258, allowing emerge --keep-going to skip the package if possible. All of the gpg stderr output is dumped before the exception is raised, as shown in bug 920258 comment #0.

Bug: https://bugs.gentoo.org/920258

@zmedico zmedico force-pushed the bug_920258_run_pkg_pretend_unpack_metadata_SignatureException branch from b6e4fe4 to 7436f94 Compare December 26, 2023 21:46
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind looking at the general lock-on-updates bit as well? I think it'll probably be worth making a release then with the existing binpkg fixes + that in master.

This will handle the InvalidSignature exception that triggered
bug 920258, allowing emerge --keep-going to skip the package
if possible. All of the gpg stderr output is dumped before the
exception is raised, as shown in bug 920258 comment #0.

Bug: https://bugs.gentoo.org/920258
Signed-off-by: Zac Medico <zmedico@gentoo.org>
@zmedico zmedico force-pushed the bug_920258_run_pkg_pretend_unpack_metadata_SignatureException branch from 7436f94 to fbd6909 Compare December 26, 2023 22:03
@gentoo-bot gentoo-bot merged commit fbd6909 into gentoo:master Dec 26, 2023
10 checks passed
@zmedico zmedico deleted the bug_920258_run_pkg_pretend_unpack_metadata_SignatureException branch December 26, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants