Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge-wait FEATURES setting enabled by default #1238

Merged
merged 1 commit into from Jan 16, 2024

Conversation

zmedico
Copy link
Member

@zmedico zmedico commented Jan 16, 2024

Add a new merge-wait FEATURES setting, enabled by default, which prevents packages from being merged while other packages are building. Previously, this behavior was already implemented for packages that satisfy direct or indirect dependencies of the system set. This feature can be disabled only for other packages which do not satisfy direct or indirect dependencies of the system set, in order to trade the possibility of random build failures for greater parallelism.

Currently, it is known that having merge-wait disabled can cause "random" build failures for builds using setuptools when setuptools plugins are merged during the build.

Bug: https://bugs.gentoo.org/663324

@zmedico zmedico force-pushed the bug_663324_merge-wait-feature branch 2 times, most recently from a255597 to 793b824 Compare January 16, 2024 03:40
@zmedico zmedico force-pushed the bug_663324_merge-wait-feature branch 3 times, most recently from f5877ea to e164dbc Compare January 16, 2024 05:07
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Add a new merge-wait FEATURES setting, enabled by default,
which prevents packages from being merged while other packages
are building. Previously, this behavior was already implemented
for packages that satisfy direct or indirect dependencies of
the system set. This feature can be disabled only for other
packages which do not satisfy direct or indirect dependencies
of the system set, in order to trade the possibility of random
build failures for greater parallelism.

Currently, it is known that having merge-wait disabled can
cause "random" build failures for builds using setuptools when
setuptools plugins are merged during the build.

Bug: https://bugs.gentoo.org/663324
Signed-off-by: Zac Medico <zmedico@gentoo.org>
@zmedico zmedico force-pushed the bug_663324_merge-wait-feature branch from e164dbc to 825db01 Compare January 16, 2024 05:20
@gentoo-bot gentoo-bot merged commit 825db01 into gentoo:master Jan 16, 2024
11 checks passed
@zmedico zmedico deleted the bug_663324_merge-wait-feature branch January 16, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants