GPG: Proactively stop to avoid "GPG keepalive failed" error in pypy ci jobs #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
reviewed
Feb 10, 2024
| @@ -341,10 +341,6 @@ def quickpkg_main(options, args, eout): | |||
| portage.settings.features.remove("xattr") | |||
| portage.settings.lock() | |||
|
|
|||
| if portage.settings.get("BINPKG_GPG_SIGNING_KEY", None): | |||
There was a problem hiding this comment.
I wasn't sure if this was OK because of unmerge-backup and downgrade-backup but it looks like they just call the entrypoint normally.
thesamesam
approved these changes
Feb 10, 2024
…i jobs This seems to help mitigate pypy ci job hangs like those fba76a5 triggered. Bug: https://bugs.gentoo.org/924192 Signed-off-by: Zac Medico <zmedico@gentoo.org>
Use threading.Event for thread safety during GPG stop, and use the wait method to improve responsiveness for stop requests. Bug: https://bugs.gentoo.org/924192 Signed-off-by: Zac Medico <zmedico@gentoo.org>
zmedico
force-pushed
the
bug_923368_stop_gpg_keepalive_threads
branch
from
cc5ce9a
to
03be12e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPG: Proactively stop to avoid "GPG keepalive failed" error in pypy ci jobs
This seems to help mitigate pypy ci job hangs like those fba76a5 triggered.
Use threading.Event for thread safety during GPG stop, and use the wait method to improve responsiveness for stop requests.
Bug: https://bugs.gentoo.org/924192