Replace linux_reflink extension module #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floppym
force-pushed
the
py-copy-reflink
branch
2 times, most recently
from
f704f47
to
8e5716c
Compare
zmedico
reviewed
Mar 2, 2024
|
Closing in favor of #1296. |
|
Re-opening this since it has some commentary. |
floppym
force-pushed
the
py-copy-reflink
branch
5 times, most recently
from
0666ebb
to
f9d765f
Compare
thesamesam
reviewed
Mar 3, 2024
I'm currently dog fooding it with an world update of ~250 packages on my main system. No glaring issues noticed yet. |
floppym
force-pushed
the
py-copy-reflink
branch
2 times, most recently
from
012fdf8
to
464bad7
Compare
zmedico
reviewed
Mar 3, 2024
floppym
force-pushed
the
py-copy-reflink
branch
2 times, most recently
from
9857682
to
3e9a817
Compare
dwfreed
suggested changes
Mar 9, 2024
floppym
force-pushed
the
py-copy-reflink
branch
4 times, most recently
from
aeac756
to
1db2b58
Compare
dwfreed
reviewed
Mar 14, 2024
floppym
force-pushed
the
py-copy-reflink
branch
2 times, most recently
from
3a40acf
to
c22dd63
Compare
thesamesam
approved these changes
Mar 15, 2024
Python 3.8 added support for copy_file_range in the os module, so we can just call that directly. Also, we can use the FICLONE ioctl for fast file clones on supported filesystems (btrfs). Signed-off-by: Mike Gilbert <floppym@gentoo.org>
Actually create sparse blocks at the start and end. Check file size before/after copying. Ensure sparse output when _fastcopy succeeds. Signed-off-by: Mike Gilbert <floppym@gentoo.org>
floppym
force-pushed
the
py-copy-reflink
branch
from
c22dd63
to
0cc3f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 added support for copy_file_range in the os module, so we can just call that directly.
Also, we can use the FICLONE ioctl for fast file clones on supported filesystems (btrfs).
If we think this needs some performance testing, I would appreciate any help with that.