New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: don't use ipv6 for rsync when it's disabled #1309
base: master
Are you sure you want to change the base?
Conversation
eb986f9
to
67c9dee
Compare
Thanks @0x501D this looks great! Can you add a sign off to comply with our Certificate of Origin? |
67c9dee
to
23d1a48
Compare
Sign off added. |
23d1a48
to
cf099c6
Compare
Linter errors was fixed. |
Nit: there is no "built-in" _has_ipv6() function. I would refer to |
cf099c6
to
580bd8d
Compare
Thanks. Commit message was fixed. |
I suppose we should remove the underscore from the front of the function name if we are going to call it from another module. It's no longer a "private" function. |
580bd8d
to
38d7d8f
Compare
Done. Added in a separate commit. |
Signed-off-by: Pavel Balaev <mail@void.so>
38d7d8f
to
3d586ce
Compare
socket.has_ipv6 gives a false result: $ sysctl net.ipv6.conf.all.disable_ipv6=1 net.ipv6.conf.all.disable_ipv6 = 1 $ python Python 3.11.8 (main, Feb 24 2024, 17:10:38) [GCC 13.2.1 20240210] on linux >>> import socket >>> socket.has_ipv6 True This patch uses the portage.process.has_ipv6() function, which returns the correct result. Bug: https://bugs.gentoo.org/927241 Signed-off-by: Pavel Balaev <mail@void.so>
3d586ce
to
ba5e293
Compare
Perfect, thank you. |
socket.has_ipv6 gives a false result:
This patch uses the built-in _has_ipv6() function, which returns the correct result.
Bug: https://bugs.gentoo.org/927241