Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binpkgs info to mtimedb resume data #1339

Merged

Conversation

zmedico
Copy link
Member

@zmedico zmedico commented Jun 3, 2024

In order to fix emerge --resume and --keep-going to make appropriate binary package selections, store a list of binpkgs in the resume data. By adding the data as a new key which older versions of portage will ignore, the extension is backward compatible.

Without this fix, emerge --resume and --keep-going make poor package selection choices which do not account for the --binpkg-respect-use option.

Bug: https://bugs.gentoo.org/933442

In order to fix emerge --resume and --keep-going to make
appropriate binary package selections, store a list of
binpkgs in the resume data. By adding the data as a new
key which older versions of portage will ignore, the
extension is backward compatible.

Without this fix, emerge --resume and --keep-going make
poor package selection choices which do not account for
the --binpkg-respect-use option.

Bug: https://bugs.gentoo.org/933442
Signed-off-by: Zac Medico <zmedico@gentoo.org>
@zmedico zmedico requested a review from thesamesam June 3, 2024 01:57
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I haven't verified that older Portage ignores it, but it looks like it should.

@gentoo-bot gentoo-bot merged commit 3a9f2c0 into gentoo:master Jun 3, 2024
13 checks passed
@zmedico zmedico deleted the bug_933442_mtimedb_resume_binpkgs branch June 3, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants