copyfile: fix compiling against musl libc #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native C module for copying files directly in-kernel is using the `loff_t` data type, which is defined in fcntl.h. While the file seems to be indirectly included when building with glibc, it breaks compiling with musl libc. Fix the issue by directly including fcntl.h. Define GNU_SOURCE as the typedef is guarded by this preprocessor macro.
|
Can we just replace loff_t with off64_t, so that we can keep things more portable by avoiding the _GNU_SOURCE define? |
|
Yes, that's an acceptable solution. I tested to make sure. |
|
I'm thinking with should use off_t along with the Large File Support macros (-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE) in extra_compile_args. |
|
Just did some quick tests with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native C module for copying files directly in-kernel is using the
loff_tdata type, which is defined in fcntl.h. While the file seems tobe indirectly included when building with glibc, it breaks compiling
with musl libc.
Fix the issue by directly including fcntl.h. Define GNU_SOURCE as the
typedef is guarded by this preprocessor macro.