eapply_user: combine sort for all dirs (bug 608880) #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmedico
force-pushed
the
bug_608880
branch
3 times, most recently
from
63640d4
to
967b4c6
Compare
mrueg
reviewed
Aug 10, 2017
bin/phase-helpers.sh
Outdated
| eapply "${f}" | ||
| applied=1 | ||
| fi | ||
| done < <(printf -- "%s\0" "${!_eapply_user_patches[@]}" | |
There was a problem hiding this comment.
shellcheck: ^-- SC1117: Backslash is literal in "\0". Prefer explicit escaping: "\0".
https://github.com/koalaman/shellcheck/wiki/SC1117
There was a problem hiding this comment.
I'd dare say a more readable fix would be to use single quotes, i.e. '%s\0'.
There was a problem hiding this comment.
Yeah that's better. Done now.
nicolasbock
approved these changes
Aug 11, 2017
mrueg
approved these changes
Aug 11, 2017
Combine the patch basenames from all matched directories into a list, and apply them in POSIX sorted order. This allows patches in more-specific directories to override patches of the same basename found in less-specific directories. An empty patch (or /dev/null symlink) negates a patch with the same basename found in a less-specific directory. This behavior is much more flexible and intuitive than the previous one, while remaining backward-compatible to some extent. NOTE: The implementation uses an associative array, which requires bash version 4 or later. X-Gentoo-bug: 608880 X-Gentoo-bug-url: https://bugs.gentoo.org/608880 Reviewed-by: Manuel Rüger <mrueg@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the patch basenames from all matched directories into a
list, and apply them in POSIX sorted order. This allows patches in
more-specific directories to override patches of the same basename found
in less-specific directories. An empty patch (or /dev/null symlink)
negates a patch with the same basename found in a less-specific
directory.
This behavior is much more flexible and intuitive than the previous one,
while remaining backward-compatible to some extent.
NOTE: The implementation uses an associative array, which requires bash
version 4 or later.
X-Gentoo-bug: 608880
X-Gentoo-bug-url: https://bugs.gentoo.org/608880