postinst-qa-check.d: fix [[ ${files[@]} ]] logic in for loops #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a separate all_files array to accumulate the results
from all loops, so that [[ ${files[@]} ]] only checks for
files found during the current loop.
zmedico
force-pushed
the
postinst-qa-check.d-for-loop-files-var
branch
from
4677a3b
to
b6bb36e
Compare
… run When caches were missing, calls to eqatag could be prohibitively expensive when a large number of files where found. Those files did not necessaryily belong to the current package, so it was also a false positive. Bug: https://bugs.gentoo.org/631454
zmedico
force-pushed
the
postinst-qa-check.d-for-loop-files-var
branch
from
b6bb36e
to
361f820
Compare
|
There's a fixup in 743bedc. |
mgorny
reviewed
Sep 20, 2017
| @@ -1,12 +1,12 @@ | |||
| # check for missing calls to gnome2-utils regen functions | |||
|
|
|||
| gnome2_icon_cache_check() { | |||
| local d f files=() find_args | |||
| local d f all_files=() find_args | |||
There was a problem hiding this comment.
There's no point in including find_args here if you local it later.
There was a problem hiding this comment.
FIxed in 5fc7281, thanks.
| @@ -27,15 +27,16 @@ gnome2_icon_cache_check() { | |||
| # (note: yes, it will eagerly repeat the update for next dirs | |||
There was a problem hiding this comment.
This comment is no longer valid now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a separate all_files array to accumulate the results
from all loops, so that [[ ${files[@]} ]] only checks for
files found during the current loop.