Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncioEventLoop: exit after unhandled exception (bug 658684) #327

Merged
merged 1 commit into from Jun 27, 2018

Conversation

zmedico
Copy link
Member

@zmedico zmedico commented Jun 22, 2018

Fix portage commands to exit immediately for any unhandled
exceptions that are raised while the asyncio event loop is running
without a tty. If we have a tty then start the debugger,
since in might aid in diagnosis of the problem.

In order to avoid potential interference with API consumers, do not
call set_exception_handler unless portage._internal_caller is True.

Bug: https://bugs.gentoo.org/658684

@zmedico zmedico force-pushed the bug_658684_set_exception_handler branch from 79dfdcc to 05efc04 Compare June 23, 2018 22:18
Fix portage commands to exit immediately for any unhandled
exceptions that are raised while the asyncio event loop is running
without a tty. If we have a tty then start the debugger,
since in might aid in diagnosis of the problem.

In order to avoid potential interference with API consumers, do not
call set_exception_handler unless portage._internal_caller is True.

Bug: https://bugs.gentoo.org/658684
@zmedico zmedico force-pushed the bug_658684_set_exception_handler branch from 05efc04 to 6b50ba6 Compare June 27, 2018 03:05
@gentoo-bot gentoo-bot merged commit 6b50ba6 into gentoo:master Jun 27, 2018
@zmedico zmedico deleted the bug_658684_set_exception_handler branch June 27, 2018 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants