Make features USE respect RESTRICT=test (bug 663278) #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgorny
approved these changes
Aug 11, 2018
Make RESTRICT=test prevent the "test" USE flag from being added to features USE flags when FEATURES=test is enabled, in order to preserve default behavior for ebuilds that set RESTRICT=test. The code that sets the restrict_test variable in the setcpv method must execute earlier now, but the logic is unchanged. Note that it is still possible to enable USE=test for ebuilds that set RESTRICT=test, but FEATURES=test will not do it, so it will only be triggered by an explicit USE=test setting by the user or profile. Fixes: 8c5598c ("Replace implicit {FEATURES->USE}=test forcing with USE default") Bug: https://bugs.gentoo.org/663278 Reviewed-by: Michał Górny <mgorny@gentoo.org>
zmedico
force-pushed
the
bug_663278_features_use_restrict_test
branch
from
8c482b7
to
abf6f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make RESTRICT=test prevent the "test" USE flag from being added to
features USE flags when FEATURES=test is enabled, in order to preserve
default behavior for ebuilds that set RESTRICT=test. The code that sets
the restrict_test variable in the setcpv method must execute earlier
now, but the logic is unchanged. Note that it is still possible to
enable USE=test for ebuilds that set RESTRICT=test, but FEATURES=test
will not do it, so it will only be triggered by an explicit USE=test
setting by the user or profile.
Fixes: 8c5598c ("Replace implicit {FEATURES->USE}=test forcing with USE default")
Bug: https://bugs.gentoo.org/663278