New changes metamanifest #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the test failure looks like was only the lack of the new gkeys dep... somehting that should be ready by end of GSOC... there are some other changes to add for using it to come. |
| else: | ||
| self.checkFileHashes('MANIFEST', f, ignoreMissing=False) | ||
| if verify_pkgs: | ||
| new_mfpath = os.path.join(mfdir, f.replace("Manifest", "")) |
There was a problem hiding this comment.
That's kind of an odd use of replace. This seems more appropriate
new_mfpath = os.path.dirname(os.path.join(mfdir, f))
angelos-p
force-pushed
the
new_changes_metamanifest
branch
from
68d4591
to
43b4380
Compare
| else: | ||
| raise portage.exception.PortageException("!!! gpg exited with '" + str(return_code) + "' status") | ||
|
|
||
| def find_reporoot(self): |
There was a problem hiding this comment.
I think the reporoot and the repolevel should be constructor parameters, since it's very inefficient for each Manifest instance to have to figure this stuff out automatically.
angelos-p
force-pushed
the
new_changes_metamanifest
branch
from
43b4380
to
47b5ec0
Compare
|
GLEP 58 has been replaced by GLEP 74 which is already implemented on the infrastructure side. See bug 638908. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for a GSoC project based on GLEP:58
Added more
MANIFEST_IDENTIFIERSinpym/portage/const.pyaccording to GLEP:60Modified
guessManifestType()for the newMANIFEST_IDENTIFIERSand reduced the return statementsUpdated some variable names in
/pym/portage/manifest.pyAdded a new file
/pym/portage/meta-manifest.pywhich includes a subclass of Manifest for manifest files outside of the packages (ex. /profiles, categories etc)Added 4
create_functions for it,create_cat()that creates a metamanifest for categories that includes the manifest files of all packages after verifying them,create_profileandcreate_eclassthat create a metamanifest for the/profilesand/eclassdirectories, andcreate_masterthat creates a metamanifest file that includes all the metamanifests above and all files in the root directory.Added signature and manifest verification to the metamanifest files which verifies package manifests only if a boolean is passed and ignores missing categories or packages if the whole directory is missing.
Modified the
checkFileHashes()method in the subclass to ignoreDISTfiles because otherwise package manifests wouldn't be verifiable.Added some methods to help me identify things like the repolevel, reporoot and repotype.
Modified the
create()function to choose whichcreate_function to use based on the repotype.Instructions on how to use the script: https://goo.gl/i0LIay
Test cases: https://wiki.gentoo.org/wiki/User:Aeroniero