Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emerge: enable parallel-fetch during pkg_pretend (bug 710432) #625

Merged

Conversation

zmedico
Copy link
Member

@zmedico zmedico commented Sep 20, 2020

Execute pkg_pretend phases in a coroutine while parallel-fetch
is running concurrently. When it's time to execute the pkg_pretend
phase for a remote binary package, use a Scheduler _get_prefetcher
method to get a running prefetcher if available, and otherwise
start a new fetcher.

Since pkg_pretend phases now run inside of the --keep-going retry
loop, --keep-going is now able to recover from pkg_pretend
failures, which fixes bug 404157.

Bug: https://bugs.gentoo.org/404157
Bug: https://bugs.gentoo.org/710432

@zmedico zmedico force-pushed the bug_710432_pkg_pretend_parallel-fetch branch from 12d41f9 to 76b5b15 Compare September 20, 2020 02:24
lib/_emerge/Scheduler.py Outdated Show resolved Hide resolved
@zmedico zmedico changed the title emerge: enable parallel-fetch during pkg_pretend (bug 710432) WIP: emerge: enable parallel-fetch during pkg_pretend (bug 710432) Sep 20, 2020
@zmedico zmedico force-pushed the bug_710432_pkg_pretend_parallel-fetch branch 5 times, most recently from 2590441 to a93f20b Compare September 21, 2020 04:56
@zmedico zmedico changed the title WIP: emerge: enable parallel-fetch during pkg_pretend (bug 710432) emerge: enable parallel-fetch during pkg_pretend (bug 710432) Sep 21, 2020
@zmedico zmedico force-pushed the bug_710432_pkg_pretend_parallel-fetch branch from a93f20b to 1bc6ac4 Compare September 21, 2020 05:03
Execute pkg_pretend phases in a coroutine while parallel-fetch
is running concurrently. When it's time to execute the pkg_pretend
phase for a remote binary package, use a Scheduler _get_prefetcher
method to get a running prefetcher if available, and otherwise
start a new fetcher.

Since pkg_pretend phases now run inside of the --keep-going retry
loop, --keep-going is now able to recover from pkg_pretend
failures, which fixes bug 404157.

Bug: https://bugs.gentoo.org/404157
Bug: https://bugs.gentoo.org/710432
Signed-off-by: Zac Medico <zmedico@gentoo.org>
@zmedico zmedico force-pushed the bug_710432_pkg_pretend_parallel-fetch branch from 1bc6ac4 to c7fa3f1 Compare September 21, 2020 05:48
@gentoo-bot gentoo-bot merged commit c7fa3f1 into gentoo:master Sep 21, 2020
@zmedico zmedico deleted the bug_710432_pkg_pretend_parallel-fetch branch September 21, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants