Detect and report incorrect use of <stabilize-allarches/> #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report a QA warning when <stabilize-allarches/> is used on a package installing ELF files. We can easily check this through presence of (non-empty) NEEDED build-info files.
zmedico
reviewed
May 31, 2021
zmedico
approved these changes
May 31, 2021
Arfrever
reviewed
Jun 2, 2021
| eqawarn "$(while read -r x; do x=${x#*;} ; x=${x%%;*} ; echo "${x#${EPREFIX}}" ; done < "${PORTAGE_BUILDDIR}"/build-info/NEEDED.ELF.2)" | ||
| if [[ -s ${PORTAGE_BUILDDIR}/build-info/NEEDED.ELF.2 ]]; then | ||
| if grep -qs '<stabilize-allarches/>' "${EBUILD%/*}/metadata.xml"; then | ||
| eqawarn "QA Notice: stabilize-allarches/> found on package installing ELF files" |
There was a problem hiding this comment.
Missing < before stabilize-allarches/> in this message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report a QA warning when is used on a package
installing ELF files. We can easily check this through presence of
(non-empty) NEEDED build-info files.