estrip: avoid calling scanelf twice #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmedico
reviewed
Mar 16, 2022
We can use the previous scanelf data to not call it again to find all of the dynamically linked executables/libraries which need stripping. Bug: https://bugs.gentoo.org/749624 Signed-off-by: Sam James <sam@gentoo.org>
|
Thank you! |
heroxbd
reviewed
Jul 18, 2022
| find "$@" -type f ! -type l -name '*.a' | ||
| cut -d ' ' -f1 < "${PORTAGE_BUILDDIR}"/build-info/NEEDED \ | ||
| | sed -e "s:^:${ED}:" |
There was a problem hiding this comment.
build-info/NEEDED is with EPREFIX. The following sed with ED gives double prefix.
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
The content of build-info/NEEDED is with EPREFIX, the following sed should only prepend the paths with D. Bug: https://bugs.gentoo.org/749624 Bug: https://bugs.gentoo.org/858818 Reference: #794 Signed-off-by: Benda Xu <heroxbd@gentoo.org> Signed-off-by: Sam James <sam@gentoo.org>
genbtc
pushed a commit
to genbtc/portage
that referenced
this pull request
Aug 15, 2022
The content of build-info/NEEDED is with EPREFIX, the following sed should only prepend the paths with D. Bug: https://bugs.gentoo.org/749624 Bug: https://bugs.gentoo.org/858818 Reference: gentoo#794 Signed-off-by: Benda Xu <heroxbd@gentoo.org> Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the previous scanelf data to not call it again to find
all of the dynamically linked executables/libraries which need stripping.
Bug: https://bugs.gentoo.org/749624
Signed-off-by: Sam James sam@gentoo.org