Avoid calling root-level logging functions #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, establish a named logger in each module. This will allow for easier filtering of log messages if we ever expand the use of the logging module. Signed-off-by: Mike Gilbert <floppym@gentoo.org>
thesamesam
approved these changes
Jul 9, 2022
|
FWIW, I'd probably wait until after we tag 3.0.31 for this, not that it's really risky though, more that it's big enough, but it's only a very weak preference. |
I agree. |
genbtc
pushed a commit
to genbtc/portage
that referenced
this pull request
Aug 15, 2022
Instead, establish a named logger in each module. This will allow for easier filtering of log messages if we ever expand the use of the logging module. Closes: gentoo#849 Signed-off-by: Mike Gilbert <floppym@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, establish a named logger in each module. This will allow for easier filtering of log messages if we ever expand the use of the logging module.