news: fix isRelevant check #853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifested as all news items being shown, even if (very) irrelevant to the running system (e.g. different arch, packages not installed, ...). I think the distinction here is that with the previous state, we'd end up with _only_ Trues, or nothing (an element would be omitted), whereas this commit means we end up considering a possible mixed sequence. Fixes: 9e24d01 Reported-by: kurly Signed-off-by: Sam James <sam@gentoo.org>
floppym
approved these changes
Jul 11, 2022
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Jul 12, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
|
Merged. |
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Jul 12, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Jul 20, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Sep 20, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Sep 20, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Sep 29, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Sep 29, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Oct 12, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Nov 2, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Nov 15, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Dec 5, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Dec 14, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Dec 15, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Dec 24, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Dec 31, 2022
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Jan 10, 2023
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Jan 10, 2023
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Sep 26, 2023
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Sep 26, 2023
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Oct 1, 2023
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
thesamesam
added a commit
to thesamesam/portage
that referenced
this pull request
Oct 1, 2023
Noticed when reviewing commits after the news issue (see referenced PR). This should be equivalent but I think it's more readable this way (ditching the negatives). Fixes: 9e24d01 See: gentoo#853 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifested as all news items being shown, even if
(very) irrelevant to the running system (e.g.
different arch, packages not installed, ...).
I think the distinction here is that with the previous state,
we'd end up with only Trues, or nothing (an element
would be omitted), whereas this commit means we end
up considering a possible mixed sequence.
Fixes: 9e24d01
Reported-by: kurly
Signed-off-by: Sam James sam@gentoo.org