Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/ecompress: add lz4 command line options #892

Closed
wants to merge 1 commit into from

Conversation

rndxelement
Copy link
Contributor

@rndxelement rndxelement commented Aug 19, 2022

Calling lz4 with mutliple files results in
warnings of the form:

Warning : <path>/<file> won't be used ! Do you want multiple input files (-m) ?

Adding the -m option to the lz4 call
resolves this issue.
Additionally, the --rm option will remove
the source files after a successful compression.

Bug: https://bugs.gentoo.org/672916
Signed-off-by: Philipp Rösner rndxelement@protonmail.com

@floppym
Copy link
Contributor

floppym commented Aug 19, 2022

From the lz4 man page:

       -m --multiple
              Multiple input files. Compressed file names will be appended a  .lz4  suffix.  This
              mode  also reduces notification level. Can also be used to list multiple files. lz4
              -m has a behavior equivalent to gzip -k (it preserves source files by default).

Do we also need to add --rm to delete the uncompressed file after successful compression?

@rndxelement
Copy link
Contributor Author

From the lz4 man page:

       -m --multiple
              Multiple input files. Compressed file names will be appended a  .lz4  suffix.  This
              mode  also reduces notification level. Can also be used to list multiple files. lz4
              -m has a behavior equivalent to gzip -k (it preserves source files by default).

Do we also need to add --rm to delete the uncompressed file after successful compression?

Thanks. I added it.
Also from the lz4 man page:

•   lz4 preserves original files
•   It´s possible to opt-in to erase source files on successful compression or decompression, using --rm command.
•   Consequently, lz4 -m --rm behaves the same as gzip.

Calling lz4 with mutliple files results in
warnings of the form:

`Warning : <path>/<file> won't be used !
Do you want multiple input files (-m) ?`

Adding the `-m` option to the lz4 call
resolves this issue.
Additionally, the `--rm` option will remove
the source files after a successful compression.

Bug: https://bugs.gentoo.org/672916
Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
@rndxelement rndxelement changed the title bin/ecompress: fix multi-file lz4 compression bin/ecompress: add lz4 command line options Aug 19, 2022
@floppym
Copy link
Contributor

floppym commented Aug 19, 2022

I'll merge this once CI finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants