Fix some type errors

[xxc3nsoredxx]

Knock out some low-hanging fruit given by running

mypy --pretty --show-error-context .

inside lib/ (191 total errors found).

portage/package/ebuild/_config/special_env_vars.py:248: error: Incompatible types in assignment (expression has type "FrozenSet[str]", variable has type "List[str]")  [assignment]
    environ_whitelist = frozenset(environ_whitelist)
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
portage/package/ebuild/_config/special_env_vars.py:353: error: Incompatible types in assignment (expression has type "FrozenSet[str]", variable has type "List[str]")  [assignment]
    environ_filter = frozenset(environ_filter)
                     ^~~~~~~~~~~~~~~~~~~~~~~~~
portage/__init__.py: note: At top level:
portage/__init__.py:537: error: Need type annotation for "_testing_eapis" [var-annotated]
    _testing_eapis = frozenset([])
                     ^~~~~~~~~~~~~
portage/checksum.py:342: error: Incompatible types in assignment (expression has type "int", variable has type "bool")  [assignment]
            prelink_capable = 1
                              ^
portage/process.py:64: error: Incompatible types in assignment (expression has type "None", variable has type "str")  [assignment]
            _fd_dir = None
                      ^~~~
portage/process.py:68: error: Incompatible types in assignment (expression has type "None", variable has type "str")  [assignment]
        _fd_dir = None
                  ^~~~
_emerge/Package.py: note: At top level:
_emerge/Package.py:865: error: Incompatible types in assignment (expression has type "FrozenSet[str]", variable has type "Set[str]")  [assignment]
    _all_metadata_keys = frozenset(_all_metadata_keys)
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
portage/getbinpkg.py:46: error: Incompatible types in assignment (expression has type "Tuple[Type[Exception], ...]", variable has type "List[Type[Exception]]")  [assignment]
    _all_errors = tuple(_all_errors)
                  ^~~~~~~~~~~~~~~~~~

Signed-off-by: Oskari Pirhonen xxc3ncoredxx@gmail.com

[xxc3nsoredxx]

Setting in lib/portage/__init__.py

_testing_eapis = frozenset([""])

was incorrect since that would result in eapi_is_supported() returning True for empty string. Reverted.

[floppym]

This certainly looks nicer.

I'm a bit suspicious of this expression in the original code: x for x in portage.auxdbkeys. If auxdbkeys is already a collection, I wonder why we piled a generator on top.

[xxc3nsoredxx]

It seems to come from when elements of auxdbkeys were conditionally included, up until 1dbe0f2

--- a/lib/_emerge/Package.py
+++ b/lib/_emerge/Package.py
@@ -791,8 +791,7 @@ def with_use(self, use):
 			pkg = self
 		return pkg
 
-_all_metadata_keys = set(x for x in portage.auxdbkeys \
-	if not x.startswith("UNUSED_"))
+_all_metadata_keys = set(x for x in portage.auxdbkeys)
 _all_metadata_keys.update(Package.metadata_keys)
 _all_metadata_keys = frozenset(_all_metadata_keys)

Some of the x for x did get dropped, so it was probably oversight.

[floppym]

Ah, that explanation makes me feel better. Thanks!