app-emulation/wine-mono: add shared support #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
|
what do you mean? |
|
Like commit this code |
|
i don't understand what you mean by "need". i have been testing this change for some months in my overlay. i would like to contribute it for other users to use. since i am not allowed to push to gentoo or wine repositories, i have opened PRs for review and merging. if you want to accept it, i would appreciate it. if you do not, i will continue to maintain it myself. |
|
@Hello71 He was just asking if you had privileges to commit/push it to the repository yourself. He is happy to accept the contribution (hence approval). |
|
Yeah sorry I wasn't sure if you had push permission. I'll push it now. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Xu (Hello71) alex_y_xu@yahoo.ca