Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: 1.54 cannot update Dokuwiki any more #2

Closed
hartwork opened this issue Jul 5, 2015 · 6 comments
Closed

Regression: 1.54 cannot update Dokuwiki any more #2

hartwork opened this issue Jul 5, 2015 · 6 comments

Comments

@hartwork
Copy link
Member

hartwork commented Jul 5, 2015

It seems I cannot udpate Dokuwiki any more. webapp-config is complaining that the version I am passing is invalid. I don't see why:

# webapp-config --user apache --group apache --host www.example.org -d '.' --upgrade dokuwiki 20140929d
* Fatal error: Invalid package version: 20140929d
* Fatal error(s) - aborting

# webapp-config --user apache --group apache --host www.example.org -d '.' --upgrade dokuwiki 20140929d-r1
* Fatal error: Invalid package version: 20140929d-r1
* Fatal error(s) - aborting

# ls -d1 /var/db/pkg/www-apps/dokuwiki-*
/var/db/pkg/www-apps/dokuwiki-20140929b
/var/db/pkg/www-apps/dokuwiki-20140929c
/var/db/pkg/www-apps/dokuwiki-20140929d
/var/db/pkg/www-apps/dokuwiki-20140929d-r1

If this is not a bug, please help me understand what I am doing wrong. Many thanks!
@hartwork
Copy link
Member Author

I downgraded to 1.53-r2 by now. With 1.53-r2, the upgrade works without complaints:

# webapp-config --user apache --group apache --host www.example.org --upgrade dokuwiki 20140929d-r1
* Upgrading /dokuwiki-20140929c to /dokuwiki-20140929d-r1
[..]
* Install completed - success

@hartwork hartwork changed the title Version 1.54 cannot update Dokuwiki any more? Regression: 1.54 cannot update Dokuwiki any more Jul 11, 2015
@twitch153
Copy link
Contributor

That'd be an issue on my part. I'll fix it and release a new revision of webapp-config-1.54 with the patch 👍

@hartwork
Copy link
Member Author

Cool, thank you!

@twitch153
Copy link
Contributor

Not a problem! Thank you for letting me know.

twitch153 pushed a commit that referenced this issue Jul 11, 2015
config.py: Fixes package version checking regression
9e251c7 
Previously webapp-config would not do any sanity checks when
setting the package version. After adding a sanity check in 1.54
I made the mistake of not being flexible enough and this caused
a regression that prevented web apps with versions such as
"20140929d"[1] to be installed. This commit fixes that while still
allowing for some sanity checking.

[1]: #2
@twitch153
Copy link
Contributor

The ebuild is on the tree and the fix is in the repo, I'll be closing this issue now.

@hartwork
Copy link
Member Author

Excellent, thank you!

For the record, it's commit 9e251c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hartwork @twitch153