-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge permalink panel code into permalink component #109
Comments
I can work on that on Friday, if no one else takes this on, and if the other works on the permalink panel are done. |
I'm actually no longer sure about that. Sorry. I now tend to think that it makes sense to have a "permalink" feature which is just a service that directives like "map", "contextmenu" et "permalinkpanel" use. What I don't like is the name "permalinkpanel". A component named "share" would make more sense to me. And talking about names, I think I'd rename "contextmenu" to "contextpopup" or something. What we're displaying on contextmenu events is not a menu really. |
+1 on all accounts. |
+1 from me as well On Fri, Jul 12, 2013 at 9:43 AM, Gilbert Jeiziner
Twitter: http://twitter.com/cedricmoullet |
This was triggere by the discussion at #109
This was triggered by the discussion in #109 Note that this requires a `make clean`
All has been addressed in the mentionned PR's |
As discussed during our weekly hangout.
The text was updated successfully, but these errors were encountered: