Remove use of $translate in ImportKml directive #185
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -202,8 +202,8 @@ | |
| }]); | ||
|
|
||
| module.directive('gaImportKml', | ||
| ['$http', '$log', '$compile', '$translate', 'gaBrowserSniffer', | ||
| function($http, $log, $compile, $translate, gaBrowserSniffer) { | ||
| return { | ||
| retsrict: 'A', | ||
| templateUrl: 'components/importkml/partials/importkml.html', | ||
|
|
@@ -255,9 +255,13 @@ | |
| // Register drag'n'drop events on <body> | ||
| var dropZone = angular.element( | ||
| '<div class="import-kml-drop-zone">' + | ||
| ' <div>{{"drop_me_here" | translate}}</div>' + | ||
| '</div>'); | ||
|
|
||
| // We use $compile only for the translation, | ||
| // $translate("drop_me_here") didn't work in prod mode | ||
| $compile(dropZone)(scope); | ||
|
|
||
|
There was a problem hiding this comment. Do we know the reason why it didn't work in prod? There was a problem hiding this comment. Thanks @gjn. Wanted to ask the same. It doesn't make sense. And it may actually hide a problem. There was a problem hiding this comment. No I didn't find why. I thought it was a goog.require missing or something like that but no. And when I 've tried to debug the code with the chrome debugger it works, maybe a loading problem of json files. There was a problem hiding this comment. Differences between prod and src are usually big smells. If it was a silent failure (without any error in the console), it could mean that $translate is known but not yet initialized with the translations the moment it's called. Seems like a timing/async issue to me. We probably were just lucky in src mode. There was a problem hiding this comment. I correct what I've said: In prod mode that never works In dev mode if you clear the cache, sometimes it works sometimes no There was a problem hiding this comment. Now it makes more sense. Probably related to the asynchronous loading of translation files, as @gjn said it. We should look at the problem more closely, to understand when it triggers, otherwise we'll fall into the trap again. There was a problem hiding this comment. I confirm, when you clear the cache the async requests, which load the json files, finish after the link function is executed. I've added an issue: #198 There was a problem hiding this comment. I think $compile is needed whenever there is angular bindings inside the html snippet. So having $compile makes sense.
Edit: I know see why |
||
| var dragEnterZone = angular.element(document.body); | ||
| dragEnterZone.append(dropZone); | ||
| dragEnterZone.bind('dragenter', function(evt) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment should be removed. It is misleading because using the $translate service doesn't work either in dev mode. The directive must be used or the string won't be updated when switching languages.