Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Cancel the print process #2129

Merged
merged 1 commit into from
Feb 18, 2015
Merged

Cancel the print process #2129

merged 1 commit into from
Feb 18, 2015

Conversation

oterral
Copy link
Contributor

@oterral oterral commented Jan 29, 2015

Fix #2117

Test;

In the case a multiprint that send a cancel request to the print server.

  • chsdi needs to be modify to handle the cancel request

@oterral oterral changed the title Cancel the print process [WIP] Cancel the print process Jan 29, 2015
@gjn
Copy link
Contributor

gjn commented Jan 29, 2015

FYI, there won't be a possibility to cancel a multiprint serverside because of multiple back-ends and cookie less state.

We could work around that using zadara back-end (create and check cancel file on shared volume), but I'm not sure it's worth the pain (given how rarelry the multiprint is used).

@procrastinatio
Copy link
Contributor

@gjn I agree it is not very used, but with this PR, a single user may start, stop, change his mind and restart print jobs and destroy the server.

@gjn
Copy link
Contributor

gjn commented Feb 5, 2015

I'll create a PR tomorrow for back-end.

@gjn
Copy link
Contributor

gjn commented Feb 6, 2015

PR is back-end is ready. geoadmin/mf-chsdi3#1258

I've tested it with this branch and it works well. On deploy, also needs testing on int (because of multi-machine setup)

@procrastinatio @oterral Please test/review as well.

@oterral oterral force-pushed the teo_cancel branch 2 times, most recently from 5d3d34b to e2ad737 Compare February 18, 2015 12:37
@oterral
Copy link
Contributor Author

oterral commented Feb 18, 2015

@procrastinatio can you review pls?

@oterral oterral changed the title [WIP] Cancel the print process Cancel the print process Feb 18, 2015
@procrastinatio
Copy link
Contributor

Looks good for this part, I am testing the backend.

@oterral
Copy link
Contributor Author

oterral commented Feb 18, 2015

thx @procrastinatio

oterral pushed a commit that referenced this pull request Feb 18, 2015
@oterral oterral merged commit 2415b4d into master Feb 18, 2015
@oterral oterral deleted the teo_cancel branch February 18, 2015 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cancel button to stop print process
3 participants