[3D] 3d tilt #2609
[3D] 3d tilt #2609
Conversation
fredj
force-pushed
the
3d_tilt
branch
7 times, most recently
from
c6e9c65
to
f6dd9d6
Compare
|
demo updated |
This reverts commit bfec7d8.
|
Thanks for any review. I don't really like the new |
| // true is the selected background layer is not 3d compatible. | ||
| scope.disabled = false; | ||
| scope.$on('gaBgChange', function(evt, value) { | ||
| scope.disabled = value.id == 'ch.swisstopo.swissimage'; |
There was a problem hiding this comment.
Why don't you use value.disable3d here?
There was a problem hiding this comment.
disable3d property is only available in the background selector directive, not here
There was a problem hiding this comment.
it shouldn't, The valueparam should contains the disable3dproperty.
valueis a bg object with an id, a label and a disable3dif it exists
There was a problem hiding this comment.
oups, I was searching in the evt object ...
|
Question for everyone: shouldn't the mouse cursor change when hovering the 3D button and when 3D is disabled because the background layer is swissimage? Currently, the cursor is still a hand, which I think is confusing. |
|
@fredj, when I switch to 3D I sometimes get some big jump with a blue background before actually seeing the expected background. Is this a known issue? |
And when this occurs the map is not tilted after switching to 3D. I am not even sure the location is the same as the previous, 2D, location. |
yes, it's a known ol3-cesium issue |
This is correct. The UI will by done by swisstopo. |
|
I've fixed the css cursor when the feature is disabled or not available |
| // true is the selected background layer is not 3d compatible. | ||
| scope.disabled = false; | ||
| scope.$on('gaBgChange', function(evt, value) { | ||
| scope.disabled = !!value.disable3d; |
There was a problem hiding this comment.
Why !!? value.disable3d is a boolean value already, no?
|
No more comments from me. |
|
LGTM. Artwork still remains to be done. But I'll merge this. Thanks alot. |
No description provided.