Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-259: Converted topic section into composition API #664

Merged
merged 2 commits into from
Feb 28, 2024
Merged

PB-259: Converted topic section into composition API #664

merged 2 commits into from
Feb 28, 2024

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Feb 27, 2024 •
edited by github-actions bot
Loading

@ltshb ltshb marked this pull request as ready for review February 27, 2024 16:07
@ltshb ltshb requested a review from ltkum February 27, 2024 16:07
@cypress Cypress
Copy link

cypress bot commented Feb 27, 2024 •
edited
Loading

Passing run #754 ↗︎

0 168 21 0 Flakiness 0

Details:

PB-259: Converted topic section into composition API
Project: web-mapviewer Commit: 33321afa56
Status: Passed Duration: 04:42 💡
Started: Feb 28, 2024 4:53 AM Ended: Feb 28, 2024 4:58 AM

Review all test suite changes for PR #664 ↗︎

ismailsunni
ismailsunni approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ltshb ltshb force-pushed the feat-PB-259-topics-composition branch from 3c304b9 to 33321af Compare February 28, 2024 04:50
@ltshb ltshb merged commit 19ca5d7 into develop Feb 28, 2024
6 checks passed
@ltshb ltshb deleted the feat-PB-259-topics-composition branch February 28, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismailsunni ismailsunni ismailsunni approved these changes

@pakb pakb pakb approved these changes

@ltkum ltkum Awaiting requested review from ltkum

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ltshb @ismailsunni @pakb