PB-277: The mouse wheel zoom constraint had some issues with different #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #775 ↗︎
Details:
Review all test suite changes for PR #665 ↗︎ |
|||||||||||||||
|
I don't know if it is something we should tackle in the scope of this change : when we zoom through a map gesture (be it mouse wheel on desktop or pinch gesture on mobile) I would not trigger the zoom rounding computation. |
devices/os On some device and os the mouse zoom wheel was unusable (one scroll step would result to full zoom in or out). A user reported this per email and I had the issue on my private windows machine with its touchpad and with 2 different mouses. Strangely the same mouse were working fine with my HP Zbook on linux. See also openlayer issue openlayers/openlayers#15423
ltshb
force-pushed
the
bug-PB-277-mouse-wheel-zoom
branch
2 times, most recently
from
27fec8f
to
fcaf2d5
Compare
…wheel However keep the swisstopo closest zoom for the button.
ltshb
force-pushed
the
bug-PB-277-mouse-wheel-zoom
branch
from
fcaf2d5
to
d0f2c29
Compare
pakb
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devices/os
On some device and os the mouse zoom wheel was unusable (one scroll step would result to full zoom in or out). A user reported this per email and I had the issue on my private windows machine with its touchpad and with 2 different mouses. Strangely the same mouse were working fine with my HP Zbook on linux.
See also openlayer issue openlayers/openlayers#15423
Test link