Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs related to EWKB and SRID #210

Merged
merged 2 commits into from Mar 4, 2019
Merged

Improve docs related to EWKB and SRID #210

merged 2 commits into from Mar 4, 2019

Conversation

elemoine
Copy link
Member

@elemoine elemoine commented Mar 2, 2019

This PR follows up on #209.

Ping @SergeBouchut and @adrien-berchet-forcity. Also, please tell me if you need a new geoalchemy2 release on pypi.

@adrien-berchet
Copy link
Member

The doc is fine for me.
A new release would be cool for us since we delayed a feature in our internal tools because of this. But shouldn't we make the WKTElement() behaviour consistent with the new WKBElement(), i.e. extracting the SRID from EWKT when srid=-1? It should not be hard so I can make a PR for this today.

@adrien-berchet
Copy link
Member

Proposal: #211

@elemoine
Copy link
Member Author

elemoine commented Mar 4, 2019

Not sure about WKTElement. I'll have a closer look when I can.

@elemoine elemoine merged commit 3490b5a into master Mar 4, 2019
@adrien-berchet adrien-berchet deleted the ele_docs branch January 19, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elemoine @adrien-berchet