Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow geometry_type to be None at the type level to match documentation #500

Merged
merged 5 commits into from Mar 30, 2024

Conversation

logankaser
Copy link
Contributor

Description

Allow geometry_type to be None at the type level to match documentation.
Fixes a common type checking error when using geoalchemy

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the issue).
    • Please include tests that fail with the main branch and pass with the provided fix.
  • A new feature implementation or update an existing feature
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the feature).
    • Please include tests that cover every lines of the new/updated feature.
    • Please update the documentation to describe the new/updated feature.

@adrien-berchet
Copy link
Member

Hi @logankaser
Thank you very much for this work!
The other parameters of this function don't cause any issue? Because there are other parameters that are optional so I'm wondering.

@logankaser
Copy link
Contributor Author

I think we just were not using the other arguments on my team, hopefully these types are accurate as
I've not used those arguments.

@adrien-berchet
Copy link
Member

I think we just were not using the other arguments on my team, hopefully these types are accurate as I've not used those arguments.

Ok, I see :)
Thanks for the new change!

@adrien-berchet adrien-berchet merged commit 811af0b into geoalchemy:master Mar 30, 2024
10 checks passed
@adrien-berchet
Copy link
Member

Thank you very much!
I'm going to push a new release to make these change available.

@adrien-berchet
Copy link
Member

The new release is available: https://pypi.org/project/GeoAlchemy2/0.14.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants