Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #24

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update README.md #24

wants to merge 2 commits into from

Conversation

rajsite
Copy link

@rajsite rajsite commented Feb 21, 2024

The example snippet in the README shows the @geoarrow/geoarrow-js/worker entrypoint but the rollup and src/index.ts config show a worker named import instead. This updates the README to reflect that difference.

Update worker example to reflect package structure
@rajsite rajsite marked this pull request as draft February 21, 2024 01:58
@rajsite
Copy link
Author

rajsite commented Feb 21, 2024

@kylebarron This PR fixes the imports of the README example, but it looks like the README example still has other issues, see: #25

@kylebarron
Copy link
Member

I'm not really sure which is the better import; JS bundling confuses me.

As for the example, as a quick fix to have a working example, we can switch to

const originalData = arrow.makeVector(new Int32Array([1, 2, 3])).data[0];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants