Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with local installation info #484

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

Robinlovelace
Copy link
Contributor

No description provided.

python/README.md Outdated
To install versions of the package under active development, clone the repo and open the `python` directory:

```
gh repo clone geoarrow/geoarrow-rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer standard git clone syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

python/README.md Outdated

```
gh repo clone geoarrow/geoarrow-rs
cd geoarrow-rs/python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to additionally cd into one of the python packages. You can't build anything from the python dir.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

python/README.md Outdated
pip install .
```

You may need to install dependencies such as `maturin` and `pyarrow`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mention pyarrow here, (or at least in a different section) as that's an optional runtime dependency, not a build dependency. Maturin is a build dependency but not a runtime dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, updated in latest version.

python/README.md Outdated
Comment on lines 31 to 35
From there you can install the package locally with `pip`:

```
pip install .
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For local development I'd suggest using maturin directly instead.

cd python/core
virtualenv env
source ./env/bin/activate
pip install -U maturin
maturin develop

That will build the wheel and install into the current virtualenv. You should note that's a debug build, so it'll run slower though. Use --release to build a release build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and now added.

python/README.md Outdated Show resolved Hide resolved
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may move this file to a different location later, as I had in mind that python/docs/DEVELOP.md is instructions to build the docs, but this is fine for now.

python/docs/DEVELOP.md Outdated Show resolved Hide resolved
@kylebarron kylebarron enabled auto-merge (squash) January 25, 2024 18:53
@kylebarron kylebarron merged commit 5e7d275 into geoarrow:main Jan 25, 2024
6 checks passed
@Robinlovelace Robinlovelace deleted the python-readme-update branch January 25, 2024 19:48
@Robinlovelace
Copy link
Contributor Author

Yeah, I noticed that these were the doc-building docs, hence trying to put them in the README. Optimal place: /python/DEVELOP.md?

@kylebarron
Copy link
Member

Optimal place: /python/DEVELOP.md?

Possibly. It'll get more confusing/complex in the future when we also have python/proj and python/geos, as those will need their own DEVELOP.md files to describe how to set up proj and geos locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants