Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start implementing algorithm traits on both arrays and scalars #98

Merged
merged 4 commits into from
Jul 22, 2023

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Jul 22, 2023

For the rust bindings, now that the wrappers are implemented in terms of traits, it allows us to do cool stuff like avoiding dealing with Broadcastable... and just calling them on array or scalar objects directly:

fn point_array() -> PointArray {
    todo!()
}
fn point<'a>() -> Point<'a> {
    todo!()
}
fn tmp() {
    let point_array = point_array();
    let point = point();
    let a = point_array.euclidean_distance(&point_array);
    let b = x.euclidean_distance(&point);
}

The other bindings will need to still have some sort of Broadcastable object

@kylebarron kylebarron changed the title start implementing algorithms on both arrays and scalars start implementing algorithm traits on both arrays and scalars Jul 22, 2023
@kylebarron kylebarron enabled auto-merge (squash) July 22, 2023 23:25
@kylebarron kylebarron merged commit ef2077a into main Jul 22, 2023
3 checks passed
@kylebarron kylebarron deleted the kyle/trait-impls-scalar-and-array branch July 22, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant