Update Actions to use dockerized solr and remove solr_wrapper from rake CI task #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliotjordan
force-pushed
the
1059-solr-docker
branch
2 times, most recently
from
f034f93
to
3b65a68
Compare
eliotjordan
force-pushed
the
1059-solr-docker
branch
2 times, most recently
from
36ba999
to
fd15087
Compare
eliotjordan
force-pushed
the
1059-solr-docker
branch
from
fd15087
to
4219c11
Compare
eliotjordan
force-pushed
the
1059-solr-docker
branch
from
4219c11
to
de72a12
Compare
tampakis
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
CI is passing! Noticing that the developer documentation is going to need to be updated to add Docker/Lando as a dependency eventually, even though with this PR that is only true for the rake ci task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces solr_wrapper with custom solr docker image in GitHub Actions.
Closes #1059
Docker image defined here:
https://github.com/geoblacklight/geoblacklight-docker/tree/master/solr
On DockerHub:
https://hub.docker.com/repository/docker/geoblacklight/solr