Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ESRI Specs #1145

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Disable ESRI Specs #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/javascripts/geoblacklight/viewers/esri.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ GeoBlacklight.Viewer.Esri = GeoBlacklight.Viewer.Map.extend({

// remove any trailing slash from endpoint url
_this.data.url = _this.data.url.replace(/\/$/, '');

L.esri.get(_this.data.url, {}, function(error, response){
if(!error) {
_this.layerInfo = response;
Expand Down
6 changes: 5 additions & 1 deletion spec/features/esri_viewer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,19 @@

feature 'feature_layer reference', js: true do
scenario 'displays image map layer' do
skip 'CORS error - Purdue web services are down'
skip 'spec depend on potentially flaky external services'
visit solr_document_path '32653ed6-8d83-4692-8a06-bf13ffe2c018'
expect(page).to have_css '.leaflet-control-zoom', visible: true
expect(page).to have_css 'img.leaflet-image-layer', visible: true
end
scenario 'displays dynamic layer (all layers)' do
skip 'spec depend on potentially flaky external services'
visit solr_document_path '90f14ff4-1359-4beb-b931-5cb41d20ab90'
expect(page).to have_css '.leaflet-control-zoom', visible: true
expect(page).to have_css 'img.leaflet-image-layer', visible: true
end
scenario 'displays dynamic layer (single layer)' do
skip 'spec depend on potentially flaky external services'
visit solr_document_path '4669301e-b4b2-4c8b-bf40-01b968a2865b'
expect(page).to have_css '.leaflet-control-zoom', visible: true
expect(page).to have_css 'img.leaflet-image-layer', visible: true
Expand All @@ -26,11 +28,13 @@
fail
end
scenario 'displays tiled map layer' do
skip 'spec depend on potentially flaky external services'
visit solr_document_path 'nyu-test-soil-survey-map'
expect(page).to have_css '.leaflet-control-zoom', visible: true
expect(page).to have_css 'img.leaflet-tile.leaflet-tile-loaded', visible: true
end
scenario 'displays Esri WMS layer' do
skip 'spec depend on potentially flaky external services'
visit solr_document_path 'purdue-urn-f082acb1-b01e-4a08-9126-fd62a23fd9aa'
expect(page).to have_css '.leaflet-control-zoom', visible: true
expect(page).to have_css 'img.leaflet-tile.leaflet-tile-loaded', visible: true
Expand Down