Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure oembed iframe is the same height as its container #1186

Merged
merged 1 commit into from Feb 21, 2022
Merged

Ensure oembed iframe is the same height as its container #1186

merged 1 commit into from Feb 21, 2022

Conversation

eliotjordan
Copy link
Member

Closes #1185

After update:
Screen Shot 2022-02-21 at 3 46 14 PM

ewlarson
ewlarson approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@ewlarson ewlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼️

@ewlarson ewlarson merged commit 94be8de into main Feb 21, 2022
@ewlarson ewlarson deleted the 1185-iframe branch February 21, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewlarson ewlarson ewlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oembed iframe is larger than it's container
2 participants
@eliotjordan @ewlarson